berg223 commented on code in PR #24371:
URL: https://github.com/apache/pulsar/pull/24371#discussion_r2134456572
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java:
##########
@@ -1057,15 +1067,16 @@ public CompletableFuture<Map<String, BrokerLookupData>>
filterAsync(Map<String,
brokers.remove(brokerId1);
return CompletableFuture.completedFuture(brokers);
}
- },new MockBrokerFilter() {
+ }, new MockBrokerFilter() {
@Override
public CompletableFuture<Map<String, BrokerLookupData>>
filterAsync(Map<String, BrokerLookupData> brokers,
ServiceUnitId serviceUnit,
LoadManagerContext context) {
return FutureUtil.failedFuture(new
BrokerFilterException("Test"));
}
})).when(primaryLoadManager).getBrokerFilterPipeline();
- Optional<BrokerLookupData> brokerLookupData =
primaryLoadManager.assign(Optional.empty(), bundle,
LookupOptions.builder().build()).get();
+ Optional<BrokerLookupData> brokerLookupData =
+ primaryLoadManager.assign(Optional.empty(), bundle,
LookupOptions.builder().build()).get();
Review Comment:
> these look unnecessary again, perhaps due to different line length in your
IDE code style
This line has 137 characters. So the formmatting is reasonable!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]