lhotari commented on code in PR #22560: URL: https://github.com/apache/pulsar/pull/22560#discussion_r2140527334
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/MutablePositionImpl.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import org.apache.bookkeeper.mledger.Position; + +public final class MutablePositionImpl implements Position { + + private volatile long ledgerId; + private volatile long entryId; + + public MutablePositionImpl(long ledgerId, long entryId) { + this.ledgerId = ledgerId; + this.entryId = entryId; + } + + public void transfer(long ledgerId, long entryId) { Review Comment: Why is this called `transfer`? Would there be a better name? ########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/PositionFactory.java: ########## @@ -47,6 +48,18 @@ public static Position create(long ledgerId, long entryId) { return new ImmutablePositionImpl(ledgerId, entryId); } + + /** + * Create a mutable position. + * + * @param ledgerId + * @param entryId + * @return + */ + public static MutablePositionImpl createMutable(long ledgerId, long entryId) { + return new MutablePositionImpl(ledgerId, entryId); + } + Review Comment: I think we should avoid adding this to PositionFactory for now. MutablePositionImpl could be a package protected class that isn't made public in this PR and solely used for the usecase in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
