Technoboy- commented on code in PR #24432:
URL: https://github.com/apache/pulsar/pull/24432#discussion_r2157858954
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -3219,22 +3227,31 @@ private void asyncDeleteLedger(long ledgerId,
LedgerInfo info) {
}
}
- private void asyncDeleteLedger(long ledgerId, long retry) {
- if (retry <= 0) {
- log.warn("[{}] Failed to delete ledger after retries {}", name,
ledgerId);
- return;
- }
+ private CompletableFuture<Void> asyncDeleteLedger(long ledgerId, long
retry) {
+ CompletableFuture<Void> future = new CompletableFuture<>();
+ asyncDeleteLedgerWithRetry(future, ledgerId, retry);
+ return future;
+ }
+
+ private void asyncDeleteLedgerWithRetry(CompletableFuture<Void> future,
long ledgerId, long retry) {
bookKeeper.asyncDeleteLedger(ledgerId, (rc, ctx) -> {
if (isNoSuchLedgerExistsException(rc)) {
log.warn("[{}] Ledger was already deleted {}", name, ledgerId);
+ future.complete(null);
} else if (rc != BKException.Code.OK) {
log.error("[{}] Error deleting ledger {} : {}", name,
ledgerId, BKException.getMessage(rc));
+ if (retry <= 1) {
+ // The latest once of retry has failed
+ log.warn("[{}] Failed to delete ledger after retries {},
code: {}", name, ledgerId, rc);
+ future.completeExceptionally(BKException.create(rc));
+ }
Review Comment:
Do we need to add `return` here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
