dao-jun commented on code in PR #24522:
URL: https://github.com/apache/pulsar/pull/24522#discussion_r2225787009
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -132,8 +132,16 @@ public void setCloseWhenDone(boolean closeWhenDone) {
public void initiate() {
if (STATE_UPDATER.compareAndSet(OpAddEntry.this, State.OPEN,
State.INITIATED)) {
- ByteBuf duplicateBuffer = data.retainedDuplicate();
+ // Fail the add operation if the managed ledger is in a state that
prevents adding entries.
+ ManagedLedgerException exbw = ml.interceptorException;
+ if (exbw != null) {
+ ml.pendingAddEntries.remove(this);
+ this.failed(exbw);
+ // Don't recycle the object here, see:
https://lists.apache.org/thread/po08w0tkhc7q8gc5khpdft6stxnr1v2y
+ return;
+ }
Review Comment:
> And the method ManagedLedgerImpl#internalAsyncAddEntry should already have
the check for the for the state. > Once we changed the state to
FencedForInterceptorException, the new add operation will not be added to the
> pendingAddEntries?
> But from this change, it allows the managed ledger to add the OpAddEntry
to the pendingAddEntries first and
> then remove it from here.
because there is more than one place to call `initiate()`, so I check the
interceptor exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
