gaoran10 commented on code in PR #24617:
URL: https://github.com/apache/pulsar/pull/24617#discussion_r2272464504
##########
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/AvroSchemaTest.java:
##########
@@ -540,14 +531,6 @@ public void
testTimestampWithJsonDefAndJSR310ConversionEnabled(){
Assert.assertEquals(decodeWithJson, decodeWithPojo);
Assert.assertEquals(Instant.class,
decodeWithJson.getValue().getClass());
- AvroSchema<TimestampPojo> schemaWithJsonDefNoClassLoader =
Review Comment:
Why remove this case?
##########
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/AvroSchemaTest.java:
##########
@@ -506,15 +506,6 @@ public void testTimestampWithJsonDef(){
Assert.assertEquals(decodeWithJson, decodeWithPojo);
Assert.assertEquals(Instant.class,
decodeWithJson.getValue().getClass());
-
- AvroSchema<TimestampPojo> schemaWithJsonDefNoClassLoader =
Review Comment:
Why remove this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
