lhotari commented on code in PR #24624:
URL: https://github.com/apache/pulsar/pull/24624#discussion_r2273930293


##########
conf/broker.conf:
##########
@@ -1031,6 +1031,8 @@ maxConcurrentHttpRequests=1024
 # For example: zk+hierarchical://localhost:2181/ledgers
 # The metadata service uri list can also be semicolon separated values like 
below:
 # zk+hierarchical://zk1:2181;zk2:2181;zk3:2181/ledgers
+# or
+# metadata-store:zk:localhost:2181  If we set 
-Dbookkeeper.metadata.bookie.drivers=org.apache.pulsar.metadata.bookkeeper.PulsarMetadataBookieDriver
 
-Dbookkeeper.metadata.client.drivers=org.apache.pulsar.metadata.bookkeeper.PulsarMetadataClientDriver

Review Comment:
   Since `bin/pulsar` will set these system properties unless 
`BK_METADATA_OPTIONS` is set to `none`, is this comment necessary? It might be 
better to update the complete documentation for `bookkeeperMetadataServiceUri` 
to match the default settings. 
   
   
https://github.com/apache/pulsar/blob/bbf56f651ebe357745b46654a1d9fb7dc4899fd7/bin/pulsar#L349-L355



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to