lhotari commented on PR #24623: URL: https://github.com/apache/pulsar/pull/24623#issuecomment-3188151689
Here's the JMH results for the latest changes. The new `getNumberOfCursorsAtSamePositionOrBefore` behavior required for `cacheEvictionByExpectedReadCount` in `ActiveManagedCursorContainerImpl` is not causing an overhead compared to the previous `ManagedCursorContainer` tracking for slowest reader position. Here's a visualization of the results: https://jmh.morethan.io/?source=https://gist.githubusercontent.com/lhotari/0851ab4c2aadb2433ce68f49f9d2c44f/raw/d5895205601e6027d0c6c72ca61abfb071508632/jmh-result-1755168599.json [text results](https://gist.github.com/lhotari/0851ab4c2aadb2433ce68f49f9d2c44f#file-jmh-result-1755168599-txt-L1887-L1941) One interesting detail is that ActiveManagedCursorContainerImpl's algorithm would be faster than ManagedCursorContainer's algorithm for tracking the slowest cursor, assuming that most cursors are moving forward (which is the case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
