zhaizhibo commented on PR #24639: URL: https://github.com/apache/pulsar/pull/24639#issuecomment-3199580457
> Looks pretty good now. I think preserving the original logic to do the initial fetch of brokers could be useful. There's a comment about that. > There's a checkstyle error: > > ``` > [INFO] There is 1 error reported by Checkstyle 10.14.2 with /home/runner/work/pulsar/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset. > Error: src/main/java/org/apache/pulsar/broker/resources/MetadataStoreCacheLoader.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.common.util.OrderedScheduler' > ``` > > If you are using IntelliJ IDE, here are instructions how to setup the correct code style: https://pulsar.apache.org/contribute/setup-ide/#configure-code-style Organizing imports in IntelliJ after using the correct code style would fix the issue. > > Before pushing changes, this is the fastest command to validate that the project compiles and checkstyle passes for the project: > > ```shell > mvn -Pcore-modules,-main -T 1C clean install -DskipTests -Dspotbugs.skip=true -DnarPluginPhase=none > ``` done. The original log message 'Successfully updated xxx' was useful, so I added it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
