gaoran10 commented on code in PR #24488:
URL: https://github.com/apache/pulsar/pull/24488#discussion_r2306785767
##########
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaTest.java:
##########
@@ -375,7 +375,7 @@ public void
testSeparatedKeyValueEncodingTypeSchemaEncodeAndDecode() {
} catch (SchemaSerializationException e) {
Assert.assertTrue(e.getMessage().contains("This method cannot be
used under this SEPARATED encoding type"));
}
- KeyValue<Foo, Bar> keyValue = ((KeyValueSchemaImpl)
keyValueSchema).decode(fooSchema.encode(foo),
+ KeyValue<Foo, Bar> keyValue = ((KeyValueSchemaImpl)
keyValueSchema).decode(null, fooSchema.encode(foo),
Review Comment:
fixed
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java:
##########
@@ -717,4 +717,5 @@ ClientBuilder authentication(String authPluginClassName,
Map<String, String> aut
* - The `loadManagerClassName` config in broker is a class that
implements the `ExtensibleLoadManager` interface
*/
ClientBuilder lookupProperties(Map<String, String> properties);
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
