This is an automated email from the ASF dual-hosted git repository.

lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new f795bf80490 [fix][broker]Fix flaky test 
PartitionCreationTest.testCreateMissedPartitions (#24679)
f795bf80490 is described below

commit f795bf80490444fbd90528d26fb8d91bf9e34cfe
Author: fengyubiao <yubiao.f...@streamnative.io>
AuthorDate: Fri Aug 29 04:07:43 2025 +0800

    [fix][broker]Fix flaky test 
PartitionCreationTest.testCreateMissedPartitions (#24679)
---
 .../apache/pulsar/client/api/PartitionCreationTest.java   | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/PartitionCreationTest.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/PartitionCreationTest.java
index cdbc820a722..ddb3e91a730 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/PartitionCreationTest.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/PartitionCreationTest.java
@@ -18,7 +18,6 @@
  */
 package org.apache.pulsar.client.api;
 
-import java.util.concurrent.TimeUnit;
 import org.apache.pulsar.client.admin.PulsarAdminException;
 import org.apache.pulsar.client.impl.MultiTopicsConsumerImpl;
 import org.apache.pulsar.common.naming.TopicDomain;
@@ -135,15 +134,9 @@ public class PartitionCreationTest extends 
ProducerConsumerBase {
         // simulate partitioned topic without partitions
         
pulsar.getPulsarResources().getNamespaceResources().getPartitionedTopicResources()
                 .createPartitionedTopicAsync(TopicName.get(topic),
-                new PartitionedTopicMetadata(numPartitions));
-        Consumer<byte[]> consumer = null;
-        try {
-            consumer = 
pulsarClient.newConsumer().topic(topic).subscriptionName("sub-1")
-                    .subscribeAsync().get(3, TimeUnit.SECONDS);
-        } catch (Exception e) {
-            //ok here, consumer will create failed with 'Topic does not exist'
-        }
-        Assert.assertNull(consumer);
+                new PartitionedTopicMetadata(numPartitions)).join();
+        Assert.assertEquals(admin.topics().getList("public/default").stream()
+            .filter(tp -> 
TopicName.get(topic).getPartitionedTopicName().endsWith(topic)).toList().size(),
 0);
         if (useRestApi) {
             admin.topics().createMissedPartitions(topic);
         } else {
@@ -152,7 +145,7 @@ public class PartitionCreationTest extends 
ProducerConsumerBase {
                 
admin.topics().createNonPartitionedTopic(topicName.getPartition(i).toString());
             }
         }
-        consumer = 
pulsarClient.newConsumer().topic(topic).subscriptionName("sub-1").subscribe();
+        Consumer<byte[]> consumer = 
pulsarClient.newConsumer().topic(topic).subscriptionName("sub-1").subscribe();
         Assert.assertNotNull(consumer);
         Assert.assertTrue(consumer instanceof MultiTopicsConsumerImpl);
         Assert.assertEquals(((MultiTopicsConsumerImpl) 
consumer).getConsumers().size(), 3);

Reply via email to