lhotari commented on code in PR #24729:
URL: https://github.com/apache/pulsar/pull/24729#discussion_r2342065018
##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java:
##########
@@ -283,4 +283,10 @@ public PulsarAdminBuilder connectionMaxIdleSeconds(int
connectionMaxIdleSeconds)
this.conf.setConnectionMaxIdleSeconds(connectionMaxIdleSeconds);
return this;
}
+
+ @Override
+ public PulsarAdminBuilder description(String description) {
+ this.conf.setDescription(description);
+ return this;
+ }
Review Comment:
https://github.com/apache/pulsar/blob/e916457f9055cf3e292d98ffcb677518a27699f6/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java#L430-L434
Where is the check for the max 64 character limit? Please add a test that
it's not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
