Anonymitaet commented on a change in pull request #5027: [doc] Improve Pulsar 
security-tls-transport
URL: https://github.com/apache/pulsar/pull/5027#discussion_r318058709
 
 

 ##########
 File path: site2/docs/security-tls-transport.md
 ##########
 @@ -6,39 +6,39 @@ sidebar_label: Transport Encryption using TLS
 
 ## TLS Overview
 
-By default, Apache Pulsar clients communicate with the Apache Pulsar service 
in plain text, which means that all data is sent in the clear. TLS can be used 
to encrypt this traffic so that it cannot be snooped by a man-in-the-middle 
attacker.
+By default, Apache Pulsar clients communicate with the Apache Pulsar service 
in plain text. This means that all data is sent in the clear. You can use TLS 
to encrypt this traffic to protect the traffic from the snooping of a 
man-in-the-middle attacker.
 
-TLS can be configured for both encryption and authentication. You may 
configure just TLS transport encryption, which is covered in this guide. TLS 
authentication is covered [elsewhere](security-tls-authentication.md). 
Alternatively, you can use [another authentication 
mechanism](security-athenz.md) on top of TLS transport encryption.
+You can also configure TLS for both encryption and authentication. Use this 
guide to configure just TLS transport encryption and refer to 
[here](security-tls-authentication.md) for TLS authentication configuration. 
Alternatively, you can use [another authentication 
mechanism](security-athenz.md) on top of TLS transport encryption.
 
-> Note that enabling TLS may have a performance impact due to encryption 
overhead.
+> Note that enabling TLS may impact the performance due to encryption overhead.
 
 ## TLS concepts
 
-TLS is a form of [public key 
cryptography](https://en.wikipedia.org/wiki/Public-key_cryptography). 
Encryption is performed using key pairs consisting of a public key and a 
private key. Messages are encrypted with the public key and can be decrypted 
with the private key.
+TLS is a form of [public key 
cryptography](https://en.wikipedia.org/wiki/Public-key_cryptography). Using a 
key pairs consisting of a public key and a private key can perform the 
encryption. The public key encrpyts the messages and the private key decrypts 
the messages.
 
 To use TLS transport encryption, you need two kinds of key pairs, **server key 
pairs** and a **certificate authority**.
 
-A third kind of key pair, **client key pairs**, are used for [client 
authentication](security-tls-authentication.md).
+You can use a third kind of key pair, **client key pairs**, for [client 
authentication](security-tls-authentication.md).
 
-The **certificate authority** private key should be stored in a very secure 
location (a fully encrypted, disconnected, air gapped computer). The 
certificate authority public key, the **trust cert**, can be freely shared.
+You should store the **certificate authority** private key in a very secure 
location (a fully encrypted, disconnected, air gapped computer). As for the 
certificate authority public key, the **trust cert**, you can freely shared it.
 
-For both client and server key pairs, the administrator first generates a 
private key and a certificate request. Then the certificate authority private 
key is used to sign the certificate request, generating a certificate. This 
certificate is the public key for the server/client key pair.
+For both client and server key pairs, the administrator first generates a 
private key and a certificate request, then uses the certificate authority 
private key to sign the certificate request, finally generates a certificate. 
This certificate is the public key for the server/client key pair.
 
-For TLS transport encryption, the clients can use the **trust cert** to verify 
that the server they are talking to has a key pair that was signed by the 
certificate authority. A man-in-the-middle attacker would not have access to 
the certificate authority, so they couldn't create a server with such a key 
pair.
+For TLS transport encryption, the clients can use the **trust cert** to verify 
that the server has a key pair that the certificate authority signed when the 
clients are talking to the server. A man-in-the-middle attacker does not have 
access to the certificate authority, so they couldn't create a server with such 
a key pair.
 
-For TLS authentication, the server uses the **trust cert** to verify that the 
client has a key pair that was signed by the certificate authority. The Common 
Name of the **client cert** is then used as the client's role token (see 
[Overview](security-overview.md)).
+For TLS authentication, the server uses the **trust cert** to verify that the 
client has a key pair that the certificate authority signed. The Common Name of 
the **client cert** is then used as the client's role token (see 
[Overview](security-overview.md)).
 
-## Creating TLS Certificates
+## Creat TLS Certificates
 
 Creating TLS certificates for Pulsar involves creating a [certificate 
authority](#certificate-authority) (CA), [server 
certificate](#server-certificate), and [client 
certificate](#client-certificate).
 
-The following guide is an abridged guide to setting up a certificate 
authority. For a more detailed guide, there are plenty of resource on the 
internet. We recommend the [this 
guide](https://jamielinux.com/docs/openssl-certificate-authority/index.html).
+Follow the abridged guide below to set up a certificate authority. You can 
also refer to plenty of resources on the internet for a more detailed guide. We 
recommend [this 
guide](https://jamielinux.com/docs/openssl-certificate-authority/index.html) 
for your detailed reference.
 
 Review comment:
   ```suggestion
   Follow the guide below to set up a certificate authority. You can also refer 
to plenty of resources on the internet for a more detailed guide. We recommend 
[this 
guide](https://jamielinux.com/docs/openssl-certificate-authority/index.html) 
for your detailed reference.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to