lhotari commented on issue #24707:
URL: https://github.com/apache/pulsar/issues/24707#issuecomment-3298134731

   > [@lhotari](https://github.com/lhotari) Thank you for pointing out this 
issue. It seems that according to what you said, only a small change is needed. 
Seems watcherFuture should be left uncompleted if connection has never been 
established, or it will trigger recheckPatternTimeout task. If this change 
works, I will create a PR. 
[oneby-wang#3](https://github.com/oneby-wang/pulsar/pull/3).
   
   looks good. In addition, I think it would be useful to set a closed flag 
when PatternMultiTopicsConsumerImpl is closing. After the closed flag is set, 
the possible exceptionally callback for watcherFuture shouldn't trigger a 
recheckPatternTimeout task. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to