lhotari commented on code in PR #23386:
URL: https://github.com/apache/pulsar/pull/23386#discussion_r2372282023


##########
conf/broker.conf:
##########
@@ -909,6 +909,9 @@ metadataStoreBatchingMaxSizeKb=128
 # Enable authentication
 authenticationEnabled=false
 
+# Enable authentication role anonymizer, can be REDACTED, hash:SHA256, 
hash:MD5, default is NONE
+authenticationRoleLoggingAnonymizer=

Review Comment:
   This should be set to the default value in the config file, otherwise, it 
would try to set a null value
   ```suggestion
   authenticationRoleLoggingAnonymizer=NONE
   ```



##########
conf/proxy.conf:
##########
@@ -184,6 +184,9 @@ forwardAuthorizationCredentials=false
 # Whether authentication is enabled for the Pulsar proxy
 authenticationEnabled=false
 
+# Enable authentication role anonymizer, can be REDACTED, hash:SHA256, 
hash:MD5, default is NONE
+authenticationRoleLoggingAnonymizer=

Review Comment:
   This should be set to the default value in the config file, otherwise, it 
would try to set a null value
   ```suggestion
   authenticationRoleLoggingAnonymizer=NONE
   ```



##########
conf/standalone.conf:
##########
@@ -572,6 +572,9 @@ authenticateOriginalAuthData=false
 # Enable authentication
 authenticationEnabled=false
 
+# Enable authentication role anonymizer, can be REDACTED, hash:SHA256, 
hash:MD5, default is NONE
+authenticationRoleLoggingAnonymizer=

Review Comment:
   This should be set to the default value in the config file, otherwise, it 
would try to set a null value
   ```suggestion
   authenticationRoleLoggingAnonymizer=NONE
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to