Demogorgon314 commented on code in PR #24785: URL: https://github.com/apache/pulsar/pull/24785#discussion_r2384875166
########## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicLoadingContext.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.service; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.TimeUnit; +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import lombok.Setter; +import org.apache.pulsar.common.naming.TopicName; +import org.jspecify.annotations.Nullable; + +@RequiredArgsConstructor +public class TopicLoadingContext { + + private static final String EXAMPLE_LATENCY_OUTPUTS = "1234 ms (queued: 567)"; + + private final long startNs = System.nanoTime(); + @Getter + private final TopicName topicName; + @Getter + private final boolean createIfMissing; + @Getter + private final CompletableFuture<Optional<Topic>> topicFuture; + @Getter + @Setter + @Nullable private Map<String, String> properties; + private long polledFromQueueNs = -1L; + + public void polledFromQueue() { + polledFromQueueNs = System.nanoTime(); + } + + public long latencyMs(long nowInNanos) { + return TimeUnit.NANOSECONDS.toMillis(nowInNanos - startNs); + } + Review Comment: Can we add a no-arg method here? ``` public long latencyMs() { return latencyMs(System.nanoTime()); } ``` ########## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicLoadingContext.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.service; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.TimeUnit; +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import lombok.Setter; +import org.apache.pulsar.common.naming.TopicName; +import org.jspecify.annotations.Nullable; + +@RequiredArgsConstructor +public class TopicLoadingContext { + + private static final String EXAMPLE_LATENCY_OUTPUTS = "1234 ms (queued: 567)"; + + private final long startNs = System.nanoTime(); + @Getter + private final TopicName topicName; + @Getter + private final boolean createIfMissing; + @Getter + private final CompletableFuture<Optional<Topic>> topicFuture; + @Getter + @Setter + @Nullable private Map<String, String> properties; + private long polledFromQueueNs = -1L; + + public void polledFromQueue() { + polledFromQueueNs = System.nanoTime(); + } + + public long latencyMs(long nowInNanos) { + return TimeUnit.NANOSECONDS.toMillis(nowInNanos - startNs); + } + + public String latencyString(long nowInNanos) { + final var builder = new StringBuilder(EXAMPLE_LATENCY_OUTPUTS.length()); + builder.append(latencyMs(nowInNanos)); + builder.append(" ms"); + if (polledFromQueueNs >= 0) { + builder.append(" (queued: ").append(TimeUnit.NANOSECONDS.toMillis(polledFromQueueNs - startNs)).append(")"); Review Comment: ```suggestion builder.append(" (queued: ").append(latencyMs(polledFromQueueNs)).append(")"); ``` ########## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ########## @@ -1142,25 +1143,60 @@ public CompletableFuture<Optional<Topic>> getTopic(final TopicName topicName, bo return FutureUtil.failedFuture(new NotAllowedException( "Broker is unable to load persistent topic")); } - return checkNonPartitionedTopicExists(topicName).thenCompose(exists -> { + final CompletableFuture<Optional<Topic>> topicFuture = FutureUtil.createFutureWithTimeout( + Duration.ofSeconds(pulsar.getConfiguration().getTopicLoadTimeoutSeconds()), executor(), + () -> FAILED_TO_LOAD_TOPIC_TIMEOUT_EXCEPTION); + final var context = new TopicLoadingContext(topicName, createIfMissing, topicFuture); + if (properties != null) { + context.setProperties(properties); + } + topicFuture.exceptionally(t -> { + if (FutureUtil.unwrapCompletionException(t) instanceof TimeoutException) { + log.warn("Failed to load {} after {}", topicName, context.latencyMs(System.nanoTime())); Review Comment: ```suggestion log.warn("Failed to load {} after {} ms", topicName, context.latencyMs(System.nanoTime())); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
