gaoran10 opened a new pull request, #24798:
URL: https://github.com/apache/pulsar/pull/24798

   ### Motivation
   
   Currently, the Schema ID has two types, and they have different schema ID 
formats:
   - value schema ID (external schema ID data)
   - key-value schema ID (keySchemaId length (4 bytes) + keySchemaId data + 
valueSchemaId length (4 bytes) + valueSchemaId data)
   
   This will cause a problem; if users want to use the schema ID in message 
metadata, they can't distinguish the value schema ID from the key-value schema 
ID.
   
   We can add a magic header for the encoding format.
   
   ### Modifications
   
   Unify the value schema ID and key-value schema ID in this format:
   magic_byte(1 byte) + keySchemaIdLength(4 bytes) + keySchemaId + 
valueSchemaIdLength(4 bytes) + valueSchemaId
   
   The first version magic byte is 0x0.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [x] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to