lhotari commented on code in PR #24818:
URL: https://github.com/apache/pulsar/pull/24818#discussion_r2410503394
##########
pulsar-client-all/pom.xml:
##########
@@ -77,6 +77,12 @@
<artifactId>log4j-slf4j2-impl</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.bookkeeper</groupId>
+ <artifactId>bookkeeper-server</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Is this necessary?
##########
pulsar-client-shaded/pom.xml:
##########
@@ -56,6 +56,12 @@
<artifactId>pulsar-client-messagecrypto-bc</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.bookkeeper</groupId>
+ <artifactId>bookkeeper-server</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Necessary?
##########
pulsar-client-admin-shaded/pom.xml:
##########
@@ -352,10 +356,6 @@
<pattern>org.aopalliance</pattern>
<shadedPattern>org.apache.pulsar.shade.org.aopalliance</shadedPattern>
</relocation>
- <relocation>
- <pattern>org.apache.bookkeeper</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.bookkeeper</shadedPattern>
- </relocation>
Review Comment:
Do not remove the relocation of `org.apache.bookkeeper` package. Pulsar's
managed-ledger uses `org.apache.bookkeeper.mledger` package.
https://github.com/apache/pulsar/blob/e6f66dfa016fcad74ca72808fe7654f1204a5920/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java#L19
IIRC, the reason for this is that there was a plan at one point to move the
module to Apache BookKeeper, but that never happened.
##########
pulsar-client-all/pom.xml:
##########
@@ -416,10 +420,6 @@
<exclude>org.apache.avro.reflect.Union</exclude>
</excludes>
</relocation>
- <relocation>
- <pattern>org.apache.bookkeeper</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.bookkeeper</shadedPattern>
- </relocation>
Review Comment:
Do not remove the relocation of `org.apache.bookkeeper` package. Pulsar's
managed-ledger uses `org.apache.bookkeeper.mledger` package.
##########
pulsar-client-shaded/pom.xml:
##########
@@ -330,10 +334,6 @@
<exclude>org.apache.avro.reflect.Union</exclude>
</excludes>
</relocation>
- <relocation>
- <pattern>org.apache.bookkeeper</pattern>
-
<shadedPattern>org.apache.pulsar.shade.org.apache.bookkeeper</shadedPattern>
- </relocation>
Review Comment:
Do not remove the relocation of `org.apache.bookkeeper` package. Pulsar's
managed-ledger uses `org.apache.bookkeeper.mledger` package.
##########
pulsar-client-admin-shaded/pom.xml:
##########
@@ -52,6 +52,12 @@
<version>${project.parent.version}</version>
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.bookkeeper</groupId>
+ <artifactId>bookkeeper-server</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
is it necessary to add this explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
