Technoboy- commented on code in PR #24726:
URL: https://github.com/apache/pulsar/pull/24726#discussion_r2371552133
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1808,6 +1808,25 @@ public void createPersistentTopic0(final String topic,
boolean createIfMissing,
managedLedgerConfig.setManagedLedgerInterceptor(
new ManagedLedgerInterceptorImpl(interceptors,
brokerEntryPayloadProcessors));
}
+
+ // Set non-recoverable data metrics callback
+ if (pulsarStats.getBrokerOperabilityMetrics() != null) {
+ managedLedgerConfig.setNonRecoverableDataMetricsCallback(
+ new
org.apache.bookkeeper.mledger.NonRecoverableDataMetricsCallback() {
+ @Override
+ public void onSkipNonRecoverableLedger(long ledgerId) {
+
pulsarStats.getBrokerOperabilityMetrics().recordNonRecoverableLedgerSkipped();
+ }
+
+ @Override
+ public void onSkipNonRecoverableEntries(long
entryCount) {
+ for (long i = 0; i < entryCount; i++) {
+
pulsarStats.getBrokerOperabilityMetrics().recordNonRecoverableEntriesSkipped();
Review Comment:
addressed
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1808,6 +1808,25 @@ public void createPersistentTopic0(final String topic,
boolean createIfMissing,
managedLedgerConfig.setManagedLedgerInterceptor(
new ManagedLedgerInterceptorImpl(interceptors,
brokerEntryPayloadProcessors));
}
+
+ // Set non-recoverable data metrics callback
+ if (pulsarStats.getBrokerOperabilityMetrics() != null) {
+ managedLedgerConfig.setNonRecoverableDataMetricsCallback(
+ new
org.apache.bookkeeper.mledger.NonRecoverableDataMetricsCallback() {
+ @Override
+ public void onSkipNonRecoverableLedger(long ledgerId) {
+
pulsarStats.getBrokerOperabilityMetrics().recordNonRecoverableLedgerSkipped();
+ }
+
+ @Override
+ public void onSkipNonRecoverableEntries(long
entryCount) {
+ for (long i = 0; i < entryCount; i++) {
+
pulsarStats.getBrokerOperabilityMetrics().recordNonRecoverableEntriesSkipped();
Review Comment:
please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
