nodece commented on code in PR #23989:
URL: https://github.com/apache/pulsar/pull/23989#discussion_r2422431326
##########
pulsar-client/src/test/java/org/apache/pulsar/client/impl/ClientBuilderImplTest.java:
##########
@@ -172,6 +172,11 @@ public void testLoadConfAuthNotSetWhenNoPropsAvailable() {
assertThatAuthIsNotSet(auth);
}
+ @Test(expectedExceptions = IllegalArgumentException.class)
+ public void testClientBuilderWithMaxRetryTime() throws
PulsarClientException {
+ PulsarClient.builder().maxHttpRequestRetries(5).build();
+ }
+
@Test
public void testLoadConfAuthNotSetWhenEmptyAuthParamsSpecified() {
Map<String, Object> confProps = new HashMap<>();
Review Comment:
Please add tests to cover the default value and different configured values
for `maxHttpRequestRetries`. Verify both the setter and getter behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
