namest504 commented on PR #24842: URL: https://github.com/apache/pulsar/pull/24842#issuecomment-3402494293
> A different approach should be taken. Please check the comment [#24809 (review)](https://github.com/apache/pulsar/pull/24809#pullrequestreview-3334058939) . > > The current getRawMessage solution would be a breaking change for existing TableView API users since it would unnecessarily consume more memory and CPU. That's why a different approach must be taken. I've suggested to resolve the issue by adding new methods to the API for returning a TableView with Message as the type parameter. > > ```java > TableView<Message<T>> createForMessages() throws PulsarClientException; > CompletableFuture<TableView<Message<T>>> createForMessagesAsync() throws PulsarClientException; > ``` > > Would that approach solve your use case? @lhotari Thank you for your detailed feedback and guidance. I've revised the PR title. I've updated the PR to adopt the builder-based approach you suggested. This new commit implements the `createForMessages()` and `createForMessagesAsync()` methods to avoid the performance impact on existing `TableView` users. Please let me know if this new direction looks good. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
