BewareMyPower opened a new pull request, #24822:
URL: https://github.com/apache/pulsar/pull/24822

   ### Motivation
   
   See https://lists.apache.org/thread/tpd2kgl4v3x8bkw0skv0nj38rzrk56t7
   
   ### Modifications
   
   Set the 3rd argument of `getPartitionedTopicMetadata` to `true` in 
`PulsarClientImpl#getPartitionsForTopic`, which is used to query the number of 
partitions.
   
   Add `testAutoPartitionsUpdate` to cover the case. Specially, it tests a 
consumer that subscribes two partitioned topics to cover the path here: 
https://github.com/apache/pulsar/blob/008e4ebbaf5808c0f859dddabd8382991f32d3aa/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L182
   
   P.S. This test is only added to `ClientTest25`, which runs tests against 
`apachepulsar/pulsar:2.5.0` image. The current backward compatibility test 
strategy is ambiguous that only 2.2.0, 2.3.0, 2.4.0, 2.5.0 are tested. It's 
hard to cover all old versions, but only choose these 4 versions does not make 
sense. This topic should be out of the scope of this PR. Anyway, the test on 
2.5.0 can already prevent regression on the fix.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to