Denovo1998 opened a new pull request, #24865:
URL: https://github.com/apache/pulsar/pull/24865
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #24844
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please
see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
- The test testSeekWillNotEncounteredFencedError intermittently failed
because it counted "Subscription is fenced" errors that happened before the
seek was triggered.
- The test performs frequent topic unloads, which cause the consumer to
auto-reconnect and occasionally hit a fenced subscription during subscription
re-creation. This is expected during unload/reload and is unrelated to the seek
operation itself.
- The assertion intended to verify that no "Subscription is fenced" errors
occur as a result of seek(), but it was also including errors emitted before
seek(), leading to false negatives.
### Modifications
- Introduced an AtomicBoolean gate (countAfterSeek) to record "Subscription
is fenced" errors only after seek() starts.
- Default false; set to true immediately before calling
consumer.seek(msgId1).
- Updated the ClientCnx.handleError() override in the test to increment
the counter only when:
- error.getMessage() contains "Subscription is fenced", and
- countAfterSeek.get() is true.
- Kept the final assertion unchanged, now effectively validating that the
seek operation itself does not surface "Subscription is fenced" to the client.
- No changes to production code; this is a test-only fix to eliminate
flakiness while keeping the original intent of the test.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
