nodece commented on code in PR #1425:
URL: https://github.com/apache/pulsar-client-go/pull/1425#discussion_r2416123679
##########
pulsaradmin/pkg/rest/client.go:
##########
@@ -90,45 +91,45 @@ func (c *Client) doRequest(r *request) (*http.Response,
error) {
}
// MakeRequest can make a simple request and handle the response by yourself
-func (c *Client) MakeRequest(method, endpoint string) (*http.Response, error) {
+func (c *Client) MakeRequest(ctx context.Context, method, endpoint string)
(*http.Response, error) {
Review Comment:
For the public API, maintain backward compatibility by adding new methods
that accept a context parameter instead of changing existing method signatures.
Example:
```
func (c *Client) MakeRequestWithContext(ctx context.Context, method,
endpoint string) (*http.Response, error)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
