lhotari commented on code in PR #626: URL: https://github.com/apache/pulsar-helm-chart/pull/626#discussion_r2389453918
########## .ci/clusters/values-pulsar-previous-lts.yaml: ########## @@ -17,4 +17,45 @@ # under the License. # -defaultPulsarImageTag: 3.0.13 \ No newline at end of file +defaultPulsarImageTag: 3.0.13 + +# Pulsar 3.0.x runs on JDK 17, which doesn't support -XX:+ZGeneration, therefore it's necessary to +# override the PULSAR_GC options to use ZGC. + +zookeeper: + configData: + PULSAR_GC: > + -XX:+UseZGC + -XX:+AlwaysPreTouch + -XX:+UseTransparentHugePages + -XX:+ExitOnOutOfMemoryError + -XX:+DisableExplicitGC + -XX:+PerfDisableSharedMem +bookkeeper: + configData: + PULSAR_GC: > + -XX:+UseZGC + -XX:+AlwaysPreTouch + -XX:+UseTransparentHugePages + -XX:+ExitOnOutOfMemoryError + -XX:+DisableExplicitGC + -XX:+PerfDisableSharedMem +broker: + configData: + PULSAR_GC: > + -XX:+UseZGC + -XX:+AlwaysPreTouch + -XX:+UseTransparentHugePages + -XX:+ExitOnOutOfMemoryError + -XX:+DisableExplicitGC + -XX:+PerfDisableSharedMem + +proxy: Review Comment: @thomas-bousquet yes. The context of this file is to set values which work with Java 17 in CI. autorecovery is disabled for CI: https://github.com/apache/pulsar-helm-chart/blob/e9f7f1d2285e2795961bc6a9b18dfc12c9ef9c85/.ci/values-common.yaml#L57 For Java 21, you'd need to also want to set `-XX:+ZGenerational`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
