nodece commented on code in PR #24881:
URL: https://github.com/apache/pulsar/pull/24881#discussion_r2450564346
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -231,6 +231,9 @@ public void markDeleteFailed(ManagedLedgerException
exception, Object ctx) {
@Override
public void findEntryComplete(Position position, Object ctx) {
if (position != null) {
+ if (cursor.getMarkDeletedPosition() != null &&
cursor.getMarkDeletedPosition().compareTo(position) >= 0) {
Review Comment:
```suggestion
var markDeletedPosition = cursor.getMarkDeletedPosition();
if (markDeletedPosition != null &&
markDeletedPosition.compareTo(position) >= 0) {
```
Avoid NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
