lhotari commented on PR #24878: URL: https://github.com/apache/pulsar/pull/24878#issuecomment-3452174054
When adding new classes like BinaryAuthSession and BinaryAuthContext, please pay attention to add class level javadocs to explain the abstraction. It should also be considered whether an interface is used for BinaryAuthContext to make it easier to keep the API backwards compatible in the future. It's currently not clear what the extension model is and how a custom implementation could help extend the authentication logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
