This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 936b2400aaffebc6cea066df9c9650b081073e4c Author: Ruimin MA <[email protected]> AuthorDate: Mon Oct 27 22:37:40 2025 +0800 [improve][client]Add null check for Pulsar client clock configuration (#24848) (cherry picked from commit 54db7f2828fbc38a9e341b11a263716bf52fb55a) --- .../apache/pulsar/client/api/SimpleProducerConsumerTest.java | 11 +++++++++++ .../java/org/apache/pulsar/client/impl/ClientBuilderImpl.java | 1 + 2 files changed, 12 insertions(+) diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java index 4e15062b1e2..8a2ae2488e7 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java @@ -332,6 +332,17 @@ public class SimpleProducerConsumerTest extends ProducerConsumerBase { }); } + @Test(timeOut = 5000) + public void pulsarClientClockCheckTest() { + assertThatThrownBy( + () -> PulsarClient.builder() + .serviceUrl(lookupUrl.toString()) + .clock(null) + .build() + ).isInstanceOf(IllegalArgumentException.class) + .hasMessage("clock must not be null"); + } + @Test(timeOut = 100000) public void testPublishTimestampBatchEnabled() throws Exception { diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java index 5b3a52d5e42..9bbd9cebca8 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java @@ -408,6 +408,7 @@ public class ClientBuilderImpl implements ClientBuilder { @Override public ClientBuilder clock(Clock clock) { + checkArgument(clock != null, "clock must not be null"); conf.setClock(clock); return this; }
