This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 79784c00154a33b9d01e8c28c8860918fedf977f Author: Ruimin MA <[email protected]> AuthorDate: Mon Oct 27 22:37:40 2025 +0800 [improve][client]Add null check for Pulsar client clock configuration (#24848) (cherry picked from commit 54db7f2828fbc38a9e341b11a263716bf52fb55a) --- .../apache/pulsar/client/api/SimpleProducerConsumerTest.java | 11 +++++++++++ .../java/org/apache/pulsar/client/impl/ClientBuilderImpl.java | 1 + 2 files changed, 12 insertions(+) diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java index ad2a285c6aa..662f03de2fb 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java @@ -306,6 +306,17 @@ public class SimpleProducerConsumerTest extends ProducerConsumerBase { }); } + @Test(timeOut = 5000) + public void pulsarClientClockCheckTest() { + assertThatThrownBy( + () -> PulsarClient.builder() + .serviceUrl(lookupUrl.toString()) + .clock(null) + .build() + ).isInstanceOf(IllegalArgumentException.class) + .hasMessage("clock must not be null"); + } + @Test(timeOut = 100000) public void testPublishTimestampBatchEnabled() throws Exception { diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java index a9e42de1922..f801bf27b13 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java @@ -365,6 +365,7 @@ public class ClientBuilderImpl implements ClientBuilder { @Override public ClientBuilder clock(Clock clock) { + checkArgument(clock != null, "clock must not be null"); conf.setClock(clock); return this; }
