ivankelly commented on a change in pull request #3784: Pulsar-IO: Added Kinesis
Source Connector
URL: https://github.com/apache/pulsar/pull/3784#discussion_r318960570
##########
File path:
pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/BaseKinesisConfig.java
##########
@@ -38,7 +37,7 @@
private String awsEndpoint;
@FieldDoc(
- required = true,
+ required = false,
Review comment:
it should be either/or for this and endpoint. if region is set, you should
be able to leave endpoint blank
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
