lhotari commented on code in PR #24937:
URL: https://github.com/apache/pulsar/pull/24937#discussion_r2487001334


##########
pom.xml:
##########
@@ -369,6 +369,8 @@ flexible messaging model and an intuitive client 
API.</description>
     <extra-enforcer-rules.version>1.6.1</extra-enforcer-rules.version>
     <oshi.version>6.4.0</oshi.version>
     <checkerframework.version>3.33.0</checkerframework.version>
+
+    <nimbus.version>9.37.4</nimbus.version>

Review Comment:
   Please use more specific version property name
   ```suggestion
       <nimbus-jose-jwt.version>9.37.4</nimbus-jose-jwt.version>
   ```



##########
pom.xml:
##########
@@ -1736,6 +1738,12 @@ flexible messaging model and an intuitive client 
API.</description>
         <artifactId>opentelemetry-semconv</artifactId>
         <version>${opentelemetry.semconv.version}</version>
       </dependency>
+      <!-- enforce nimbus-jose-jwt version that gets pulled transitively -->
+      <dependency>
+        <groupId>com.nimbusds</groupId>
+        <artifactId>nimbus-jose-jwt</artifactId>
+        <version>${nimbus.version}</version>

Review Comment:
   ```suggestion
           <version>${nimbus-jose-jwt.version}</version>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to