Copilot commented on code in PR #22:
URL:
https://github.com/apache/pulsar-java-contrib/pull/22#discussion_r2489124193
##########
pulsar-admin-mcp-contrib/pom.xml:
##########
@@ -79,15 +79,12 @@
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client</artifactId>
+ <version>${default.pulsar.version}</version>
</dependency>
<dependency>
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client-admin</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-client-admin</artifactId>
+ <version>${default.pulsar.version}</version>
Review Comment:
The `pulsar-client-admin` dependency is missing the `<scope>test</scope>`
that was present in the removed duplicate declaration. If this dependency is
only needed for tests, the test scope should be retained on line 42.
```suggestion
<version>${default.pulsar.version}</version>
<scope>test</scope>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
