BewareMyPower opened a new pull request, #24947:
URL: https://github.com/apache/pulsar/pull/24947

   ### Motivation
   
   The cherry-picking on a399b5ccd317282e8624135e49e08843c7196887 inserts the 
topic future cache duplicatedly.
   
   1st time:
   
https://github.com/apache/pulsar/blob/74931c9e5f2f4384ed3b048101051dd8e5ea4a9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1129
   
   or
   
   
https://github.com/apache/pulsar/blob/74931c9e5f2f4384ed3b048101051dd8e5ea4a9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1141
   
   2nd time: 
https://github.com/apache/pulsar/blob/74931c9e5f2f4384ed3b048101051dd8e5ea4a9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1146
   
   In this case, topic future might fail with timeout. This error was exposed 
after 
https://github.com/apache/pulsar/commit/dd149d4ba4b9bc59bbc793fb083abe09252be5bf
 because the future completed with `LowOverheadTimeoutException` won't trigger 
the cache invalidation.
   
   ### Modifications
   
   Move the `fetchPartitionedTopicMetadataAsync` check to 
`loadOrCreatePersistentTopic`.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to