lhotari commented on PR #24962: URL: https://github.com/apache/pulsar/pull/24962#issuecomment-3511539386
> `BinaryProtoLookupService#getTopicsUnderNamespace` currently does not deduplicate concurrent requests with identical parameters (`namespace`, `mode`, `topicsPattern`, `topicsHash`). For each call, it creates a new `CompletableFuture` and immediately invokes the helper to obtain a connection and send a request, which can cause request amplification when multiple components query the same namespace simultaneously. @vinkal-chudgar This change itself is reasonable, but I'm just wondering if this PR is addressing a real problem. How common would it be to have multiple consumers with exactly the same topics pattern using the same Pulsar client instance? Do you have this use case your self? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
