poorbarcode commented on code in PR #24938:
URL: https://github.com/apache/pulsar/pull/24938#discussion_r2518817935
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1453,6 +1453,23 @@ public Position getFirstPosition() {
return firstLedgerId == null ? null :
PositionFactory.create(firstLedgerId, 0);
}
+ /**
+ * Compare two positions. It is different with {@link
Position#compareTo(Position)} when the params are invalid.
+ * For example: position-1 is "1:{latest entry}", and position-2 is "2:0",
they are the same position.
+ */
+ private int comparePositions(Position pos1, Position pos2) {
+ if (pos1 == null || pos2 == null) {
+ throw new IllegalArgumentException("Positions must not be null");
+ }
+ if (pos1.getLedgerId() == pos2.getLedgerId() && pos1.getEntryId() ==
pos2.getEntryId()) {
+ return 0;
+ }
+ if (!ledger.isValidPosition(pos1) || !ledger.isValidPosition(pos2)) {
+ return
ledger.getNextValidPosition(pos1).compareTo(ledger.getNextValidPosition(pos2));
+ }
Review Comment:
> Why is it wrong? Explaining that in more detail could help them understand
the purpose of your code.
Regarding [the code you wrote
above](https://github.com/apache/pulsar/pull/24938#discussion_r2517541713) ,
there is an example:
- ledgers: `[{ledger-1: 10 entris}, {ledger-2: 10 entries}]`
- `position-1`: `2 : -1`, which is the same as `2: 9`
- `position-2`: `2 : 0`
- the correct result of comparing is `-1`
- but your code will return `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
