asafm commented on code in PR #24994:
URL: https://github.com/apache/pulsar/pull/24994#discussion_r2534386987


##########
pulsar-opentelemetry/src/test/java/org/apache/pulsar/opentelemetry/OpenTelemetryServiceTest.java:
##########
@@ -116,9 +114,8 @@ public void testResourceAttributesAreSet() throws Exception 
{
             .allSatisfy(metric -> assertThat(metric)
                 .hasResourceSatisfying(resource -> resource
                     .hasAttribute(OpenTelemetryAttributes.PULSAR_CLUSTER, 
"testServiceNameAndVersion")
-                    .hasAttribute(ResourceAttributes.SERVICE_NAME, 
"openTelemetryServiceTestService")
-                    .hasAttribute(ResourceAttributes.SERVICE_VERSION, "1.0.0")
-                    .hasAttribute(satisfies(ResourceAttributes.HOST_NAME, 
AbstractCharSequenceAssert::isNotBlank))));

Review Comment:
   Do you know why the host_name attributes disappeared?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to