Jennifer88huang commented on a change in pull request #5069: [doc] Improve Pulsar Security Kerberos URL: https://github.com/apache/pulsar/pull/5069#discussion_r319384788
########## File path: site2/docs/security-kerberos.md ########## @@ -160,13 +156,13 @@ In client application, include `pulsar-client-auth-sasl` in your project depende </dependency> ``` -configure the authentication type to use `AuthenticationSasl`, and also provide the authentication parameters to it. +Configure the authentication type to use `AuthenticationSasl`, and also provide the authentication parameters to it. -There are 2 parameters needed: -- `saslJaasClientSectionName` is corresponding to the section in JAAS configuration file for client; -- `serverType` stands for whether this client is connect to broker or proxy, and client use this parameter to know which server side principal should be used. +You need 2 parameters: +- `saslJaasClientSectionName`, which is corresponding to the section in JAAS configuration file for client; +- `serverType`, which stands for whether this client is connected to broker or proxy. And client uses this parameter to know this client should use which server side principal. -When authenticate between client and broker with the setting in above JAAS configuration file, we need to set `saslJaasClientSectionName` to `PulsarClient` and `serverType` to `broker`. +When you authenticates between client and broker with the setting in above JAAS configuration file, we need to set `saslJaasClientSectionName` to `PulsarClient` and set `serverType` to `broker`. Review comment: "you authenticates" or "you authenticate"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services