lhotari opened a new pull request, #25006: URL: https://github.com/apache/pulsar/pull/25006
Fixes #23193 ### Motivation There's currently a NPE that happens when a multi-topic consumer has been closed and there are pending messages buffered in the message listener executor's queue. ### Modifications - skip processing messages in the listener when the client has already been closed - make `unAckedMessageTracker` final and don't set it to null while closing a multi-topic consumer - add tests that validate that processing of messages are skipped when the consumer has been closed - add TestLogAppender that can collect Log4J events during the test run. It's useful for asserting that the logs don't contain any errors. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
