lhotari opened a new pull request, #25008: URL: https://github.com/apache/pulsar/pull/25008
### Motivation There's a bug in the isValidConsumerEpoch method: https://github.com/apache/pulsar/blob/807dcaf5d928f8202c1bf8b8402cfcf72a41e63d/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java#L1307-L1319 There's a call to both `message.release()` and `message.recycle()`. `message.release()` will call `recycle()` when it's a pooled message: https://github.com/apache/pulsar/blob/807dcaf5d928f8202c1bf8b8402cfcf72a41e63d/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java#L738-L744 This is why it's a problem if both `release()` and `recycle()` are called. ### Modifications Remove the `message.recycle()` call. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
