poorbarcode commented on code in PR #24652:
URL: https://github.com/apache/pulsar/pull/24652#discussion_r2560605923
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -2236,11 +2237,11 @@ protected CompletableFuture<Void>
addReplicationCluster(String remoteCluster, Ma
String localCluster) {
return
AbstractReplicator.validatePartitionedTopicAsync(PersistentTopic.this.getName(),
brokerService)
.thenCompose(__ ->
brokerService.pulsar().getPulsarResources().getClusterResources()
- .getClusterAsync(remoteCluster)
- .thenApply(clusterData ->
-
brokerService.getReplicationClient(remoteCluster, clusterData)))
- .thenAccept(replicationClient -> {
- if (replicationClient == null) {
+ .getClusterAsync(remoteCluster))
+ .thenAccept((clusterData) -> {
+ PulsarClient replicationClient =
brokerService.getReplicationClient(remoteCluster, clusterData);
+ PulsarAdmin replicationAdmin =
brokerService.getClusterPulsarAdmin(remoteCluster, clusterData);
Review Comment:
The mehod is noty a asynchronous method, see
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1716-L1720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
