RobertIndie commented on code in PR #1443:
URL: https://github.com/apache/pulsar-client-go/pull/1443#discussion_r2576586086


##########
pulsar/consumer_zero_queue.go:
##########
@@ -71,11 +73,18 @@ func newZeroConsumer(client *client, options 
ConsumerOptions, topic string,
                return nil, err
        }
        opts := newPartitionConsumerOpts(zc.topic, zc.consumerName, 
tn.Partition, zc.options)
-       conn, err := newPartitionConsumer(zc, zc.client, opts, zc.messageCh, 
zc.dlq, zc.metrics)
+       opts.zeroQueueConsumer = zc
+       opts.zeroQueueReconnectedPolicy = func(pc *partitionConsumer, z 
*zeroQueueConsumer) {

Review Comment:
   Is it better to capture the `*zeroQueueConsumer` in the lambda so that we 
can simplfy the `zeroQueueReconnectedPolicy`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to