lhotari commented on code in PR #25034:
URL: https://github.com/apache/pulsar/pull/25034#discussion_r2585837529
##########
conf/log4j2.yaml:
##########
@@ -53,10 +53,14 @@ Configuration:
# Console
Console:
- name: Console
- target: SYSTEM_OUT
- PatternLayout:
- Pattern: "%d{ISO8601_OFFSET_DATE_TIME_HHMM} [%t] %-5level %logger{36}
- %msg%n"
+ - name: Console
+ target: SYSTEM_OUT
+ PatternLayout:
+ Pattern: "%d{ISO8601_OFFSET_DATE_TIME_HHMM} [%t] %-5level
%logger{36} - %msg%n"
+ - name: ConsoleJsonEcs
Review Comment:
This could be called `ConsoleJson`
##########
conf/log4j2.yaml:
##########
@@ -53,10 +53,14 @@ Configuration:
# Console
Console:
- name: Console
- target: SYSTEM_OUT
- PatternLayout:
- Pattern: "%d{ISO8601_OFFSET_DATE_TIME_HHMM} [%t] %-5level %logger{36}
- %msg%n"
+ - name: Console
+ target: SYSTEM_OUT
+ PatternLayout:
+ Pattern: "%d{ISO8601_OFFSET_DATE_TIME_HHMM} [%t] %-5level
%logger{36} - %msg%n"
+ - name: ConsoleJsonEcs
+ target: SYSTEM_OUT
+ JsonTemplateLayout:
+ eventTemplateUri: "classpath:EcsLayout.json"
Review Comment:
instead of hard coding the value to `classpath:EcsLayout.json`, it would be
useful to use a property value so that the value can be passed as a system
property. For example `pulsar.log.console.json.template`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
