lhotari commented on code in PR #25031:
URL: https://github.com/apache/pulsar/pull/25031#discussion_r2587809085
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -794,6 +794,7 @@ && shouldAntiAffinityNamespaceUnload(namespaceName,
bundleRange, broker)) {
}
}
+ writeBrokerDataOnZooKeeper(true);
Review Comment:
This wouldn't prevent race conditions. It seems that the method body of
org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl#updateAll
method should be wrapped with `synchronized (bundleSplitStrategy) {` to
prevent race conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
