3pacccccc opened a new pull request, #25039: URL: https://github.com/apache/pulsar/pull/25039
### Motivation The method `InMemTransactionBuffer.appendBufferToTxn` currently returns `null` upon successful completion. This return value is inconsistent with the method's declared return type of `CompletableFuture<Position>` and can cause `NullPointerException` for downstream callers that expect a non-null `Position` object. ### Modifications 1. Modified the successful completion path to return a concrete `Position` object (`PositionFactory.create(-1, -1)`) instead of `null`. 2. Made the `InMemTransactionBuffer` class `public` to allow for testing via the `InMemTransactionBufferProvider`. 3. Added a new unit test (`testAppendBufferToTxnWithInMemTransactionBuffer`) to verify that the method returns the expected `Position`. <!-- Describe the modifications you've done. --> ### Verifying this change - [x] Make sure that the change passes the CI checks. *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/3pacccccc/pulsar/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
