lhotari commented on PR #25044: URL: https://github.com/apache/pulsar/pull/25044#issuecomment-3620986501
> I’ll look through the draft later. BTW, is there anything I can help with? 👀 @Ksnz Thank you. For this particular PR, I think that review feedback, challenging the assumptions and testing the solution in real-world scenarios is most helpful. I pushed a follow up PR to address the performance and it's now very good since 1 million snapshots are added (while handling eviction) to the cache in just over 1 second (it was around 17 to 18 seconds without optimizing the algorithm). Each snapshot consumes around 200 bytes of memory. With max snapshot size of 100 snapshots and 5000 replicated subscriptions, in the worst case scenario, about 100 MB of heap would be consumed for snapshots. That seems reasonable, and I think that increasing from `replicatedSubscriptionsSnapshotMaxCachedPerSubscription` from `10` to `100` is a viable new default configuration option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
