lhotari commented on PR #16651: URL: https://github.com/apache/pulsar/pull/16651#issuecomment-3628439115
> There's another related flaw in the replicated subscription snapshots that should be fixed. The commit [50ca143](https://github.com/apache/pulsar/commit/50ca143829272a7d7c6f68231de22303709aa404) is already in this direction, but a similar one is needed for the responses. Fixing this would also avoid the current solution of two rounds of snapshot requests when there are more than 2 remote clusters. In addition, it's still required to have something to track the last non-marker message before the snapshot request. That position should be used instead of the snapshot request's message id as the position for the completed snapshot. That would mean reverting some of the reverted changes in commit [dae88dc](https://github.com/apache/pulsar/commit/dae88dc3eea52245abe59fd749be2fe5720ba570) This turned out to be the incorrect direction. However, one change that continues to make sense is cb2d873. In the case of the replication snapshot response, the request position would be sent back instead of the latest topic position. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
