3pacccccc commented on code in PR #25053:
URL: https://github.com/apache/pulsar/pull/25053#discussion_r2606338122
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java:
##########
@@ -423,6 +434,7 @@ public CompletableFuture<Void> updateTxnStatus(TxnID txnID,
TxnStatus newStatus,
abortedTransactionCount.increment();
}
txnMetaMap.remove(txnID.getLeastSigBits());
+ onGoingTxnCount.decrement();
Review Comment:
Thanks for catching this! It's indeed a valid race condition concern. I've
updated the code accordingly. PTAL when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
