oneby-wang opened a new pull request, #25069: URL: https://github.com/apache/pulsar/pull/25069
Fixes https://github.com/apache/pulsar/issues/25060 ### Motivation See issue's description: `TopicsImpl#getListAsync(String namespace, TopicDomain topicDomain, Map<QueryParam, Object> params))` method passes invalid parameter type to `Map.get()`. As this is an admin client Topics API method, we should keep this method despite being marked as deprecated, because the specific version for its removal has not been specified. ### Modifications Add unit test to reproduce the issue, and pass the correct param type to `Map.get()`. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/oneby-wang/pulsar/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
