poorbarcode commented on code in PR #25047:
URL: https://github.com/apache/pulsar/pull/25047#discussion_r2618564040
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorImpl.java:
##########
@@ -101,11 +101,13 @@ void recover(final VoidCallback callback) {
@Override
protected void internalAsyncMarkDelete(final Position newPosition,
Map<String, Long> properties,
- final MarkDeleteCallback callback, final Object ctx) {
+ final MarkDeleteCallback callback, final Object ctx, Runnable
alignAcknowledgeStatusAfterPersisted) {
// Bypass persistence of mark-delete position and individually deleted
messages info
- MarkDeleteEntry mdEntry = new MarkDeleteEntry(newPosition, properties,
callback, ctx);
+ MarkDeleteEntry mdEntry = new MarkDeleteEntry(newPosition, properties,
callback, ctx,
+ alignAcknowledgeStatusAfterPersisted);
lastMarkDeleteEntry = mdEntry;
+ mdEntry.alignAcknowledgeStatus();
Review Comment:
Good point, added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
