poorbarcode commented on code in PR #24873:
URL: https://github.com/apache/pulsar/pull/24873#discussion_r2621642566
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java:
##########
@@ -615,6 +615,44 @@ ClientBuilder authentication(String authPluginClassName,
Map<String, String> aut
*/
ClientBuilder openTelemetry(io.opentelemetry.api.OpenTelemetry
openTelemetry);
+ /**
+ * Enable OpenTelemetry distributed tracing.
+ *
+ * <p>When enabled, interceptors are automatically added to all producers
and consumers
+ * to create spans for message publishing and consumption, and
automatically propagate trace context
+ * via message properties.
+ *
+ * <p>This method is useful when OpenTelemetry is configured globally
(e.g., via Java Agent or
+ * {@link io.opentelemetry.api.GlobalOpenTelemetry}) and you just want to
enable tracing interceptors
+ * without explicitly setting an OpenTelemetry instance.
+ *
+ * <p>Example with Java Agent:
+ * <pre>{@code
+ * // When using -javaagent:opentelemetry-javaagent.jar
+ * PulsarClient client = PulsarClient.builder()
+ * .serviceUrl("pulsar://localhost:6650")
+ * .enableTracing(true) // Use GlobalOpenTelemetry
+ * .build();
+ * }</pre>
+ *
+ * <p>Example with GlobalOpenTelemetry:
+ * <pre>{@code
+ * // Configure GlobalOpenTelemetry elsewhere in your application
+ * GlobalOpenTelemetry.set(myOpenTelemetry);
+ *
+ * // Just enable tracing in the client
+ * PulsarClient client = PulsarClient.builder()
+ * .serviceUrl("pulsar://localhost:6650")
+ * .enableTracing(true)
+ * .build();
+ * }</pre>
+ *
+ * @param tracingEnabled whether to enable tracing (default: false)
+ * @return the client builder instance
+ * @since 4.2.0
+ */
+ ClientBuilder enableTracing(boolean tracingEnabled);
Review Comment:
收否区分类型？
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java:
##########
@@ -615,6 +615,44 @@ ClientBuilder authentication(String authPluginClassName,
Map<String, String> aut
*/
ClientBuilder openTelemetry(io.opentelemetry.api.OpenTelemetry
openTelemetry);
+ /**
+ * Enable OpenTelemetry distributed tracing.
+ *
+ * <p>When enabled, interceptors are automatically added to all producers
and consumers
+ * to create spans for message publishing and consumption, and
automatically propagate trace context
+ * via message properties.
+ *
+ * <p>This method is useful when OpenTelemetry is configured globally
(e.g., via Java Agent or
+ * {@link io.opentelemetry.api.GlobalOpenTelemetry}) and you just want to
enable tracing interceptors
+ * without explicitly setting an OpenTelemetry instance.
+ *
+ * <p>Example with Java Agent:
+ * <pre>{@code
+ * // When using -javaagent:opentelemetry-javaagent.jar
+ * PulsarClient client = PulsarClient.builder()
+ * .serviceUrl("pulsar://localhost:6650")
+ * .enableTracing(true) // Use GlobalOpenTelemetry
+ * .build();
+ * }</pre>
+ *
+ * <p>Example with GlobalOpenTelemetry:
+ * <pre>{@code
+ * // Configure GlobalOpenTelemetry elsewhere in your application
+ * GlobalOpenTelemetry.set(myOpenTelemetry);
+ *
+ * // Just enable tracing in the client
+ * PulsarClient client = PulsarClient.builder()
+ * .serviceUrl("pulsar://localhost:6650")
+ * .enableTracing(true)
+ * .build();
+ * }</pre>
+ *
+ * @param tracingEnabled whether to enable tracing (default: false)
+ * @return the client builder instance
+ * @since 4.2.0
+ */
+ ClientBuilder enableTracing(boolean tracingEnabled);
Review Comment:
收否区分类型？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
