TakaHiR07 commented on code in PR #25076:
URL: https://github.com/apache/pulsar/pull/25076#discussion_r2634282643


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########


Review Comment:
   Great catch. I have checked the earliest fixed delay implementation in 
https://github.com/apache/pulsar/pull/16609. In the earliest implementation, 
the issue is already exist. When duplicate addMessage(), 
highestDeliveryTimeTracked is ok, but messagesHaveFixedDelay would be set to 
false incorrectly.
   
   I would check why exist duplicate addMessage() later. And I prefer that we 
open another pr to fix the additional issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to